Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The hints on the branding page is using the wrong product name #1276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

votdev
Copy link
Member

@votdev votdev commented Feb 4, 2025

Summary

The hints on the Branding page at Advanced > Settings > UI > branding are using the product name Rancher instead of Harvester.

Related Issue
harvester/harvester#6341

Screenshot/Video

After:
Bildschirmfoto vom 2025-02-04 10-35-17

The hints on the Branding page at `Advanced > Settings > UI > branding` are using the product name `Rancher` instead of `Harvester`.

Related to: harvester/harvester#6341

Signed-off-by: Volker Theile <[email protected]>
@a110605
Copy link
Collaborator

a110605 commented Feb 5, 2025

I would suggest NOT to modify in shell as we need to port the same PR change to harvester-ui-extension.

You can add harvester specific keys. See https://github.com/harvester/harvester-ui-extension/compare/main...a110605:change_product_name?expand=1

Result

Screenshot 2025-02-05 at 1 30 46 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Require backport v1.3 This change require open backport PR to v1.3 Require backport v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants