Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vm rows reactivity #1262

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Fix vm rows reactivity #1262

merged 1 commit into from
Jan 13, 2025

Conversation

torchiaf
Copy link
Collaborator

@torchiaf torchiaf commented Jan 9, 2025

Summary

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue harvester/harvester#7082

Occurred changes and/or fixed issues

Technical notes summary

  • VMs are now computed values
  • Removing vmi mapping - vmi is already a vm's model property

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Screencast.from.2025-01-09.11-50-09.webm

@torchiaf torchiaf requested a review from houhoucoop January 9, 2025 10:54
@torchiaf
Fix vm rows not reactive
01e7cab 
Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf changed the title Fix vm rows not reactive Fix vm rows reactivity Jan 9, 2025
@torchiaf torchiaf mentioned this pull request Jan 9, 2025
Merged
2 tasks
houhoucoop
houhoucoop approved these changes Jan 10, 2025
View reviewed changes
Copy link

@houhoucoop houhoucoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 added Require backport v1.3 This change require open backport PR to v1.3 Require backport v1.4 and removed Require backport v1.3 This change require open backport PR to v1.3 labels Jan 10, 2025
@mergify mergify bot mentioned this pull request Jan 13, 2025
Merged
2 tasks
@torchiaf torchiaf merged commit e14713a into harvester:master Jan 13, 2025
4 checks passed
@mergify mergify bot mentioned this pull request Jan 13, 2025
Open
3 tasks
@torchiaf
Copy link
Collaborator Author

@mergify backport release-harvester-v1.3 release-harvester-v1.5

@mergify Mergify
Copy link

mergify bot commented Jan 20, 2025 •
edited
Loading

backport release-harvester-v1.3 release-harvester-v1.5

❌ No backport have been created

GitHub error: Branch not found

@mergify mergify bot mentioned this pull request Jan 20, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houhoucoop houhoucoop houhoucoop approved these changes

Assignees

@torchiaf torchiaf

Labels
Require backport v1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torchiaf @houhoucoop @a110605