Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WORKAROUND] fix create namespace page broken on rancher 2.8.x (backport #1224) #1225

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 7, 2024

Summary

shell/models/steve-schema.ts was added in #1208 which was not existed on Rancher v2.8 shell.

This PR add workaround if condition to avoid fall into below two throw new Error.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
harvester/harvester#6953

Screenshot/Video

image


This is an automatic backport of pull request #1224 done by Mergify.

@mergify mergify bot added the Backport to v1.4 Backport PR target v1.4 label Nov 7, 2024
@mergify mergify bot assigned a110605 Nov 7, 2024
@a110605 a110605 requested a review from torchiaf November 7, 2024 09:40
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torchiaf torchiaf merged commit ffea3d7 into release-harvester-v1.4 Nov 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.4 Backport PR target v1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants