Port app-modal to harvester shell (backport #1163) (target release-harvester-v1.3) #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Signed-off-by: andy.lee <[email protected]> (cherry picked from commit 85b311d) # Conflicts: # pkg/harvester/edit/kubevirt.io.virtualmachine/index.vue # pkg/harvester/l10n/en-us.yaml
Signed-off-by: andy.lee <[email protected]> (cherry picked from commit 5f65595) # Conflicts: # pkg/harvester/l10n/en-us.yaml
Signed-off-by: andy.lee <[email protected]> (cherry picked from commit 874e191) # Conflicts: # pkg/harvester/edit/harvesterhci.io.host/HarvesterDisk.vue
3 tasks
Signed-off-by: andy.lee <[email protected]>
a110605
changed the title
a110605
changed the title
|
I am still testing this PR change against v1.3.2 release. |
a110605
changed the title
a110605
added
Backport to v1.3
a110605
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rancher dashboard has already replace
<modal>to<app-modal>in below two PRsPromptModal.vuerancher/dashboard#10556vue-js-modalwithapp-modalrancher/dashboard#10591PR Checklist
Related Issue #
[BUG] Can't select the harvester version to upgrade in Rancher UI
[BUG] Rancher doesn't use dark mode in popup modals when in Harvester UI
Screenshot/Video
I've tested harvester
Test on embedded mode
This is an automatic backport of pull request #1163 done by [Mergify](https://mergify.com).