Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update compose to V2, deps excl AWS #259

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Conversation

peasee
Copy link
Contributor

@peasee peasee commented Jan 8, 2024

What

  • Upgrades from Docker Compose V1 to Docker Compose V2
  • Updates dependencies excluding the AWS SDK to their latest version. The AWS SDK update has a lot of breaking changes.
  • Fixes a bug with make test-examples where destroying the previous localstack container wasn't removing the named volumes. This resulted in subsequent re-runs to error, as the queue being created already existed.
  • Changes dependency versions to major.minor instead of major.minor.build, as the package is a library and we should let downstream packages select their desired build versions.

Why

To keep our dependencies up to date for security and performance, and to ensure our developer experience is kept up to date for testing.

@peasee peasee self-assigned this Jan 8, 2024
@peasee peasee requested a review from a team as a code owner January 8, 2024 00:44
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@peasee peasee added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit 8a27e77 Jan 8, 2024
3 checks passed
@peasee peasee deleted the fix/update-compose-and-deps branch January 8, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants