Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup subtitle preview #255

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Fixup subtitle preview #255

merged 3 commits into from
Jun 22, 2023

Conversation

jonko0493
Copy link
Member

Fixes #242

@jonko0493 jonko0493 requested a review from WiIIiam278 June 22, 2023 06:28
@jonko0493 jonko0493 self-assigned this Jun 22, 2023
WiIIiam278
WiIIiam278 approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh I thought I was running the update method there but ig not. Totally forgot to do the language conversion though

@jonko0493 jonko0493 merged commit 06f19d9 into haroohie-club:main Jun 22, 2023
@jonko0493 jonko0493 deleted the FixupSubtitlePreview branch June 22, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiIIiam278 WiIIiam278 WiIIiam278 approved these changes

Assignees

@jonko0493 jonko0493

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subtitle line preview requires modifying/updating text to get it to properly display
2 participants
@jonko0493 @WiIIiam278