Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stability with many bugfixes #251

Merged
merged 30 commits into from
Jun 21, 2023

Conversation

jonko0493
Copy link
Member

Just a grab bag of bugs fixed through testing.

  • Fixes quite a few errors with the script preview, most notably how sprites entrances/exits are handled (matches what the game does better)
  • Uses display name for BGM selector in the script editor
  • Topic links would cause crashes when clicking them before, this fixes that
  • Fixes a crash on macOS when renaming without a selected command
  • Fixes Empty script sections get deleted on build/reload but labels for those sections persist #236 by now pruning the labels section on load, preventing an issue where scripts would have lots of extraneous section references
  • The BG_DISPCG command was initialized with a TEX_BG before; this has been fixed
  • Fixes Crash when attempting to replace BGM with an MP3 #243 where trying to replace a BGM with a file that needed AOT conversion caused crashes due to me doing a bad job copying them
  • Some more character rename bugs were fixed
  • Disable fields in the puzzle and character editors that can't currently be edited
  • Fixes some errors with the Skip OP hack
  • During investigation, I found that Docker does not work on macOS at all and requires elevation on Linux. I've updated the readme and disabled those options on macOS as a result
  • We now allow loading projects even if your devkitARM installation is out of date bc that's fine as long as you're not trying to apply hacks
  • Added melonDS snap location as a preset on Linux
  • Fixed some underlying issues with NitroPacker
  • Fixed a crash related to BG_DISP being set to NONE and prevented the user from selecting none for BG_DISP and BG_DISPCG

@jonko0493 jonko0493 requested a review from WiIIiam278 June 21, 2023 21:46
@jonko0493 jonko0493 self-assigned this Jun 21, 2023
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolling with this at the moment and it's working great, much more smooth. Nothing immediately jumps out

@jonko0493 jonko0493 merged commit aba6b36 into haroohie-club:main Jun 21, 2023
@jonko0493 jonko0493 deleted the ScriptEditorQolFixes branch June 21, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants