Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down project names, add save button to the toolbar, and add view logs menu item #220

Merged
merged 4 commits into from
Jun 19, 2023

Conversation

jonko0493
Copy link
Member

@jonko0493 jonko0493 commented Jun 19, 2023

Fixes #218.

  • Project names now have a set of valid characters; attempting to type or paste invalid characters will result in input being canceled.
  • Add a save button toolbar (feedback from user study)
  • Add a view logs button to the Application/File menu (makes it easier to access the logs file; also feedback from user study). The button opens the SerialLoops.log file with the system associated program for viewing log files.

@jonko0493 jonko0493 requested a review from WiIIiam278 June 19, 2023 01:02
@jonko0493 jonko0493 self-assigned this Jun 19, 2023
Copy link
Member

@WiIIiam278 WiIIiam278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@jonko0493 jonko0493 merged commit 4578878 into haroohie-club:main Jun 19, 2023
@jonko0493 jonko0493 deleted the RestrictProjectNames branch June 19, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spaces in project name mess up ASM hacks, other things probably
2 participants