Add the ability to apply hacks #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiIIiam278
approved these changes
Jun 18, 2023
There was a problem hiding this comment.
Big fan of this -- especially the modular nature that lets users make their own hacks (might want to document that format). A few changes to make, but happy to unblock this tbh now that you've fixed the duplication issue.
I'll prepare some icons for this new stuff perhaps just before release. Only major bit of feedback is to do with the adjustments made to the preferences dialogue, but I think a quick fix for the box sizes would be fine for 0.2 :)
WiIIiam278
reviewed
Jun 18, 2023
Co-authored-by: William <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a little "Apply Hacks" dialog that provides a list of common hacks that can be applied. After checking one or more off and hitting save, the hacks are assembled and inserted into the ARM9/overlays. This PR only implements a hack to skip the OP as it was simple to implement.
Closes #108.