Add topic editing and the fruits of RE labor #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into AddTopicEditing
WiIIiam278
approved these changes
Jun 3, 2023
src/SerialLoops.Lib/Script/Parameters/FriendshipLevelScriptParameter.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99.
The headliner of this PR is the ability to edit topics. Specifically, topic names, linked scripts, and times can now be edited.
Notably, this does not include the ability to change topic types. This is because the type of the topic is inherently tied to its ID, which is actually an internal flag. Additionally, the work here helped figure out how to associate the duplicated main topics (ID + 40), so those are combined into one item, bringing the total topic count to 511 (510 topics present in-game + 1 dummy topic).
Doing the RE work here pulled back some other layers of what other things do, and unveiled that several other unknown values were also flags. Additionally, the nature of the
GLOBALcommand was revealed to actually be something that modifies "friendship levels" and thus has been renamedMODIFY_FRIENDSHIP.