Add editing for place names #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiIIiam278
approved these changes
May 14, 2023
| string spaceAdjustedText = PlaceName.Replace(" ", " "); | ||
| SKBitmap newPlaceBitmap = new(PlaceGraphic.Width, PlaceGraphic.Height); | ||
| SKCanvas canvas = new(newPlaceBitmap); | ||
| SKColor bgColor = new SKColor(0, 249, 0); |
There was a problem hiding this comment.
It might be nice to add a bool ("preview") flag to this method -- if set, instead of painting the BG green it'll just be transparent. That way, this can be passed to render a preview without the green BG, while the method can be passed without the preview bool to get the real image.
There was a problem hiding this comment.
I kind of disagree here tbh, bc GetNewPlaceGraphic shouldn't be used for previews, imo. There's a separate GetPreview method that does that; GetNewPlaceGraphic should only be used for replacing the place graphic.
|
Going to merge for now, but willing to change my mind on some feedback with further discussion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95.