Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtitle preview #188

Closed
jonko0493 opened this issue Jun 1, 2023 · 0 comments · Fixed by #189
Closed

Add subtitle preview #188

jonko0493 opened this issue Jun 1, 2023 · 0 comments · Fixed by #189
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jonko0493
Copy link
Member

jonko0493 commented Jun 1, 2023

We should expand on #187 and add a preview for subtitles to make it easier to see where they'll show up on the screen. All the information for drawing them is contained in the subtitle structs, so it shouldn't be difficult to implement this.

  • The struct contains a top/bottom screen enum which can be used to determine which screen to draw to
  • The struct contains X/Y coordinates for drawing position on the screen
  • The actual drawing routine is as follows:
    • On the top screen, the subtitle is simply drawn in white text at (X,Y)
    • On the bottom screen, the subtitle is drawn in white at (X,Y) and then drawn in black at (X+1,Y+1) and (X,Y+1) behind the white text
  • Ensure you use .Subtitle so that the formatting (#P07) is stripped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants