deploy.ts: Uses Deno.serve() instead of fetch event listener #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfo-dot
suggested changes
Aug 18, 2023
deploy.ts
Outdated
Comment on lines
89
to
92
| await client._process(interaction); | ||
| return new Response('Error', { | ||
| status: 500 | ||
| }); |
There was a problem hiding this comment.
Why is this returning error (after processing interaction)? It should be 200 as OK or 203 as empty response
There was a problem hiding this comment.
I don't think so, it only gets run if "await client.verifyFetchEvent({ request, respondWith: (res: Response) => { return res; } });" fails to return anything, and is there to avoid TS problems.
deploy.ts
Outdated
| ) | ||
| return | ||
| const interaction = await client.verifyFetchEvent({ request, respondWith: (res: Response) => { return res; } }); | ||
| if (!interaction) { |
There was a problem hiding this comment.
This here should be interaction == false
There was a problem hiding this comment.
You mean "interaction === false".
Helloyunho
requested changes
Aug 18, 2023
deploy.ts
Outdated
| export * from './src/structures/embed.ts' | ||
| export * from './src/types/messageComponents.ts' | ||
| alfiecrawford@Alfies-Air harmony-main % npx prettier deploy.ts -o output.txt | ||
| [warn] Ignored unknown option -o=output.txt. Did you mean -c? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Deno.server() should be faster, and it supports localhost for local development.
Status