Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Prevent invalid color codes from being generated #350

Merged
merged 2 commits into from
May 9, 2023
Merged

Fix: Prevent invalid color codes from being generated #350

merged 2 commits into from
May 9, 2023

Conversation

Blocksnmore
Copy link
Contributor

About

This fix makes the random hex method no longer sometimes return an invalid color code due to generating an invalid length hex code.

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

Helloyunho
Helloyunho previously approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Blocksnmore
Copy link
Contributor Author

I'm guessing that gh didn't like me fixing formatting after you reviewed it

@DjDeveloperr DjDeveloperr merged commit 5f2e642 into harmonyland:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DjDeveloperr DjDeveloperr DjDeveloperr approved these changes

@Helloyunho Helloyunho Helloyunho left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blocksnmore @Helloyunho @DjDeveloperr