feat(Member): set and reset guild timeouts #302
Conversation
|
Since Member entity already is a part of Guild, I think just |
oh ok, wanted to avoid confusion with timeouts as in network reqs |
src/structures/member.ts
Outdated
| * Resets Timeout for the Member | ||
| */ | ||
| async resetTimeout(reason?: string): Promise<Member> { | ||
| return await this.setTimeout(undefined, reason) |
There was a problem hiding this comment.
MemberData.communicationDisabledUntil is Date | undefined, it's not nullable
There was a problem hiding this comment.
huh, then it must be implemented wrong
from this it is nullable
There was a problem hiding this comment.
huh, that's pretty strange, does it function right now?
There was a problem hiding this comment.
yes, even the official discord client uses null to remove timeout
There was a problem hiding this comment.
i mean does harmony's impl work, since its wrong
There was a problem hiding this comment.
oh, probably not because undefined means that we don't want to change the value, not removing it
but again it's just MemberData type that is wrong, so changing the type or do will work@ts-ignore
There was a problem hiding this comment.
Right, we forgot to add | null to MemberData's communication_disabled_until. Can you do that, and change this to null?
About
Adds setGuildTimeout and resetGuildTimeout functions to easily modify guild timeouts for a Member.
Previously, you could only do this by using Member.edit
Status