Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(message): Set channel in message constructor #250

Merged
merged 1 commit into from
Oct 4, 2021
Merged

fix(message): Set channel in message constructor #250

merged 1 commit into from
Oct 4, 2021

Conversation

invalidCards
Copy link
Contributor

About

msg.channel.send was broken in 6d7786d due to the channel not being added to the message object. This fixes that.

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

Helloyunho
Helloyunho approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
how in the world we can break it

@Helloyunho Helloyunho merged commit 2706b57 into harmonyland:main Oct 4, 2021
@Helloyunho Helloyunho added the hacktoberfest-accepted Hacktoberfest 2021 label Oct 4, 2021
@invalidCards invalidCards deleted the fix-message-construct branch October 4, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helloyunho Helloyunho Helloyunho approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Hacktoberfest 2021
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@invalidCards @Helloyunho