🩹 fix(member): roles can be empty

harmonyland · May 30, 2023 · 5d3cf6d · 5d3cf6d
1 parent daca400
commit 5d3cf6d
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 17 deletions.
diff --git a/package.json b/package.json
@@ -18,6 +18,7 @@
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^4.2.1",
     "eslint-plugin-promise": "^6.0.0",
+    "prettier": "^2.8.8",
     "typescript": "4.7.4"
   }
 }
diff --git a/src/structures/member.ts b/src/structures/member.ts
@@ -47,28 +47,33 @@ export class Member extends SnowflakeBase {
     this.guild = guild
     this.roles = new MemberRolesManager(this.client, this.guild.roles, this)
     this.permissions = perms ?? new Permissions(Permissions.DEFAULT)
-    this.roles.array().then((roles) => {
-      const rolePermissions: string[] = []
+    this.roles
+      .array()
+      .then((roles) => {
+        const rolePermissions: string[] = []
 
-      for (const role of roles) {
-        rolePermissions.push(
-          ...role.permissions
+        for (const role of roles) {
+          rolePermissions.push(
+            ...role.permissions
+              .toArray()
+              .filter((p) => !rolePermissions.includes(p))
+          )
+        }
+
+        this.permissions.remove(
+          ...this.permissions
             .toArray()
             .filter((p) => !rolePermissions.includes(p))
         )
-      }
-
-      this.permissions.remove(
-        ...this.permissions
-          .toArray()
-          .filter((p) => !rolePermissions.includes(p))
-      )
-      this.permissions.add(
-        ...rolePermissions.filter(
-          (p) => this.permissions.toArray().includes(p) === false
+        this.permissions.add(
+          ...rolePermissions.filter(
+            (p) => this.permissions.toArray().includes(p) === false
+          )
         )
-      )
-    })
+      })
+      .catch((e) => {
+        // probably missing permissions, ignore
+      })
   }
 
   get displayName(): string {