Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR1516 suggestions #1

Merged

Conversation

RunDevelopment
Copy link

Hi @harisreedhar!

While examining the type errors in chaiNNer-org#1516, I basically fixed them all trying to understand the code more. So instead of making you do that work again, I thought that I'd just make a PR for you :)

Changes:

  • Mostly type changes. Fixed all type errors.
  • Renamed some variables and parameters.
  • Changed radius minimum to 0. This is consistent with chainner's other blur nodes.

@harisreedhar harisreedhar merged commit 5d76c6d into harisreedhar:lens_blur Jan 30, 2023
@RunDevelopment RunDevelopment deleted the pr1516-suggestions branch January 30, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants