-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
…ists in your project and is readable' message if vendor/autoload.php has been found at least once.
Hi @veger , Thank you for the PR. I have a different idea. How about the users create a So in your case it would be something like
I guess that will resolve some other issues like even if there is no composer support. And the code becoming light itself. What do you think ? |
It is a nice idea to keep the code light! But I am not allowed to add helper files, just to let tooling work, in my project root (company policy). So it is not a solution in my case. :( |
+1 on this one. |
Sure. I will consider looking into this again and merge it. Currently sick On 12-Nov-2016 17:03, "Filipe La Ruina" [email protected] wrote:
|
$foundAutoLoader = false; | ||
|
||
// First try default location | ||
if(is_readable($autoloader)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
I have a question where did this $autoloader
is assigned ? Did you missed / accidentally removed https://github.com/harikt/php-hyperclick/pull/7/files#diff-5ef8e23f048e9259d4783d28d2407b5dL5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, you are right!
The default location should be used here, but was deleted by accident.
I have updated the PR
Thank you. And sorry for keeping this wait for long. |
My
vendor/autoload.php
is not in the root of my project (as the project contains other stuff besides the source code).The improved script is able to find any
vendor/autoload.php
in the project, if it is not found in the root of the project.Additionally, changed the error message when the autoloader has been found (but the class is not), making it less obnoxious.