Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add is_local_host function #63

Merged
merged 1 commit into from
Dec 20, 2021
Merged

add is_local_host function #63

merged 1 commit into from
Dec 20, 2021

Conversation

DoobleD
Copy link
Contributor

@DoobleD DoobleD commented Nov 28, 2021

This can be used by Haraka to prevent a local delivery loop. See haraka#3002.

@msimerson
Copy link
Member

Huh, windows doesn't like resolving 'localhost' to a localhost IP. Interesting. You could git into that if you wish, or just remove that test.

@DoobleD
Copy link
Contributor Author

DoobleD commented Dec 5, 2021

Thanks for the feedback @msimerson.

Wow, that's unexpected. I couldn't find any related issue in nodejs's DNS module. Perhaps it's an issue with the CI. I'm too lazy to dig more now, so I've removed the test as suggested.

@msimerson msimerson merged commit e6e7aec into haraka:master Dec 20, 2021
@msimerson msimerson mentioned this pull request Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants