-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows node-gyp workaround testing #3052
Windows node-gyp workaround testing #3052
Conversation
FYI...I still plan to try some other ideas to resolve these problems as I have time. So don't merge into master unless some intermittent fix is desired or until I've exhausted all my ideas. I'll let you know when I give up. Node 14 on Windows 2022 might be a sticky problem. |
This PR now represents what I feel like is the minimum needed workarounds to make all of the combinations of Node and Windows versions pass. There are 2 workarounds needed:
Please merge if you find these workarounds acceptable. I will periodically test them and remove them once they no longer seem needed. |
I've also fixed the 2 Windows test fails on Node 18. There were 2 tests creating the listening port on Let me know if you'd rather split this fix from the node-gyp workaround fixes. |
maybe, if I got the syntax correct.
Thanks for your work on this issue! |
Checklist: