smtp_forward: remove redundant outbound hook #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gramakri
force-pushed
the
smtp_forward_remote_queue_outbound
branch
from
c52ab0b to
cda37d4
Compare
|
Makes sense to slap a 3.x tag onto this breaking change as some might expect particular behavior, even if it's logically wrong. |
msimerson
reviewed
May 11, 2020
Changes.md
Outdated
| @@ -21,7 +21,7 @@ | |||
| * TLS: don't abort loading certs in config/tls dir when an error is encountered. | |||
| Process every cert file and then emit errors. #2729 | |||
| * fix connection pool not being unique when hosts and ports were equal between domains #2788 | |||
|
|
|||
| * smtp_forward: this plugin does not use the queue_outbound hook anymore | |||
There was a problem hiding this comment.
can you specify in this PR when it stopped using that hook?
gramakri
force-pushed
the
smtp_forward_remote_queue_outbound
branch
from
cda37d4 to
8cbded5
Compare
msimerson
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2795
Fixes #
Changes proposed in this pull request:
Checklist: