Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New IP addresses validation #753

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

DiegoRochaHH
Copy link
Contributor

@DiegoRochaHH DiegoRochaHH commented Jan 22, 2025

Describe your changes

New validation added to give user's permissions based on a list of ip addresses. A new step with an input field has been added when you add a role to an user, there we can set the allowed ip addresses.

Type of change

Please check only ONE option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested?

This was tested on an internal project using the GCL locally together with Wiser. New test user's were created and tested with allowed and not allowed ip addresses.

Checklist before requesting a review

  • I have reviewed and tested my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I selected develop as the base branch and not main, or the pull request is a hotfix that needs to be done directly on main
  • I double checked all my changes and they contain no temporary test code, no code that is commented out and no changes that are not part of this branch
  • I added new unit tests for my changes if applicable

Related pull requests

N/A

Link to Asana ticket

https://app.asana.com/0/1206726301569963/1206726303952398/f

@DiegoRochaHH DiegoRochaHH marked this pull request as ready for review January 22, 2025 20:24
@GilianJuice GilianJuice merged commit 47bbb3d into develop Jan 23, 2025
1 check passed
@GilianJuice GilianJuice deleted the feature/new-ip-addresses-validation branch January 23, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants