Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon S3 auth changes #699

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

HansHappyHorizon
Copy link
Contributor

Describe your changes

It's now also possible to create an AmazonS3Client with only a region, or without any parameters at all. This is useful for websites hosted on AWS that authenticate themselves through AWS services internally.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested?

Checked if leaving out the access and secret keys would still create a client with only a region, and if leaving out the AWS settings completely that it would still create a client without credentials AND region.

Checklist before requesting a review

  • I have reviewed and tested my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I selected develop as the base branch and not main, or the pull request is a hotfix that needs to be done directly on main
  • I double checked all my changes and they contain no temporary test code, no code that is commented out and no changes that are not part of this branch
  • I added new unit tests for my changes if applicable

Related pull requests

N/A

Jira issue key

CON-672

It's now also possible to create an AmazonS3Client with only a region,
or without any parameters at all.
@MarkVanDijkHG MarkVanDijkHG merged commit 69fd77a into develop Nov 19, 2024
3 checks passed
@MarkVanDijkHG MarkVanDijkHG deleted the feature/amazon-s3-auth-changes branch November 19, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants