Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem with logging in users and immediately needing the cookie #692

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

GilianJuice
Copy link
Contributor

Describe your changes

Fixed problem that if we log in a user and then request the data of that user within the same request, we would get an empty result. This was because the login cookie was only added to the response, not to the current request.

This went wrong with a customer website that uses the OCI standard for placing orders. They do POST request to certain endpoints, with login credentials and an cXML that contains the order that they want to place. We need to log them in and then immediately get the user ID from the cookie and use that to place the order for that user. This went wrong, because we couldn't read the cookie at that point.

Type of change

Please check only ONE option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested?

This was tested via the same customer by simulating OCI order requests via PostMan. I was able to reproduce the issue and then verify that it was fixed.

Checklist before requesting a review

  • I have reviewed and tested my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I selected develop as the base branch and not main, or the pull request is a hotfix that needs to be done directly on main
  • I double checked all my changes and they contain no temporary test code, no code that is commented out and no changes that are not part of this branch
  • I added new unit tests for my changes if applicable

Related pull requests

N/A

Link to Asana ticket

https://app.asana.com/0/1151477971646641/1208744482937211

…hat user within the same request, we would get an empty result. This was because the login cookie was only added to the response, not to the current request.
@MarkVanDijkHG MarkVanDijkHG merged commit bb6fe41 into develop Nov 12, 2024
3 checks passed
@MarkVanDijkHG MarkVanDijkHG deleted the bugfix/login-not-visible-before-refresh branch November 12, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants