Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass StringSplitOptions in Split function instead of filtering with linq #688

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

MKet
Copy link
Contributor

@MKet MKet commented Nov 5, 2024

Describe your changes

When getting the values in extraFilterProperty it used Linq to filter out the empty values and trim to values at least it is supposed to. Instead because of a missing not operator before the String.IsNullOrWhiteSpace it didn't passthrough any values.

After fixing this I also spotted a change that should make this more efficient and I think more readable by passing StringSplitOptions to the Split method to filter out and trim the values.

Type of change

Please check only ONE option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested?

Tested on existing filter component with user the extraFilterProperty to pass in extra filter info.

Checklist before requesting a review

  • I have reviewed and tested my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I selected develop as the base branch and not main, or the pull request is a hotfix that needs to be done directly on main
  • I double checked all my changes and they contain no temporary test code, no code that is commented out and no changes that are not part of this branch
  • I added new unit tests for my changes if applicable

Related pull requests

N/A

Link to Asana ticket

https://app.asana.com/0/1204297502076149/1208684662867212/f

@HansHappyHorizon HansHappyHorizon merged commit e7e0a21 into develop Nov 6, 2024
3 checks passed
@HansHappyHorizon HansHappyHorizon deleted the bugfix/filter-extra-data branch November 6, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants