Pass StringSplitOptions in Split function instead of filtering with linq #688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When getting the values in extraFilterProperty it used Linq to filter out the empty values and trim to values at least it is supposed to. Instead because of a missing not operator before the String.IsNullOrWhiteSpace it didn't passthrough any values.
After fixing this I also spotted a change that should make this more efficient and I think more readable by passing StringSplitOptions to the Split method to filter out and trim the values.
Type of change
Please check only ONE option.
How was this tested?
Tested on existing filter component with user the extraFilterProperty to pass in extra filter info.
Checklist before requesting a review
develop
as the base branch and notmain
, or the pull request is a hotfix that needs to be done directly onmain
Related pull requests
N/A
Link to Asana ticket
https://app.asana.com/0/1204297502076149/1208684662867212/f