Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new cxml model #611

Merged
merged 7 commits into from
Aug 7, 2024
Merged

Feature/new cxml model #611

merged 7 commits into from
Aug 7, 2024

Conversation

GilianJuice
Copy link
Contributor

@GilianJuice GilianJuice commented Jul 23, 2024

Describe your changes

Added models that we need for Open Catalog Interface (OCI) connections. Also fixed a bug that cookie was immediately deleted after logging in with a session cookie. This was already fixed in the JCL the same way, but we never copied that fix to the GCL until now.

Type of change

Please check only ONE option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested?

I tested if these models can be deserialized and serialized from and to XML. Nothing else to test.

Checklist before requesting a review

  • I have reviewed and tested my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I selected develop as the base branch and not main, or the pull request is a hotfix that needs to be done directly on main
  • I double checked all my changes and they contain no temporary test code, no code that is commented out and no changes that are not part of this branch
  • I added new unit tests for my changes if applicable

Related pull requests

https://github.com/happy-geeks/HollandFoodService/pull/29

Link to Asana ticket

https://app.asana.com/0/1151477971646641/1206533774168789

alexxxx1992 and others added 4 commits June 26, 2024 12:11
… session cookie. This was already fixed in the JCL the same way, but we never copied that fix to the GCL until now.
Copy link
Contributor

@HansHappyHorizon HansHappyHorizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are inconsistencies in the attribute format across the various models. The attributes in some models contain whitespace characters before and after the = sign, whereas other models don't. So some use this format:

[XmlAttribute(AttributeName = "version")]

While others use this format:

[XmlAttribute(AttributeName="version")]

Please use one style to make it consistent. I noticed that the majority of the models use the second style (so without the the whitespace characters) so it's probably easier/faster to update using that style.

@GilianJuice
Copy link
Contributor Author

There are inconsistencies in the attribute format across the various models. The attributes in some models contain whitespace characters before and after the = sign, whereas other models don't. So some use this format:

[XmlAttribute(AttributeName = "version")]

While others use this format:

[XmlAttribute(AttributeName="version")]

Please use one style to make it consistent. I noticed that the majority of the models use the second style (so without the the whitespace characters) so it's probably easier/faster to update using that style.

Sorry, I used an external tool to generate these classes from an example XML. I didn't notice these differences. Fixed them now.

Copy link
Contributor

@HansHappyHorizon HansHappyHorizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few models that use a different format for the attributes (such as BillToModel and ChargeModel), but as it doesn't really affect anything I'm approving the PR.

@HansHappyHorizon HansHappyHorizon merged commit 5e073df into develop Aug 7, 2024
3 checks passed
@HansHappyHorizon HansHappyHorizon deleted the feature/new-cxml-model branch August 7, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants