-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/new cxml model #611
Conversation
… session cookie. This was already fixed in the JCL the same way, but we never copied that fix to the GCL until now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are inconsistencies in the attribute format across the various models. The attributes in some models contain whitespace characters before and after the =
sign, whereas other models don't. So some use this format:
[XmlAttribute(AttributeName = "version")]
While others use this format:
[XmlAttribute(AttributeName="version")]
Please use one style to make it consistent. I noticed that the majority of the models use the second style (so without the the whitespace characters) so it's probably easier/faster to update using that style.
GeeksCoreLibrary/Modules/OpenCatalogInterface/Models/CredentialModel.cs
Outdated
Show resolved
Hide resolved
GeeksCoreLibrary/Modules/OpenCatalogInterface/Models/AccountingModel.cs
Outdated
Show resolved
Hide resolved
GeeksCoreLibrary/Modules/OpenCatalogInterface/Models/CxmlPunchOutSetupResponseModel.cs
Show resolved
Hide resolved
Sorry, I used an external tool to generate these classes from an example XML. I didn't notice these differences. Fixed them now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few models that use a different format for the attributes (such as BillToModel
and ChargeModel
), but as it doesn't really affect anything I'm approving the PR.
Describe your changes
Added models that we need for Open Catalog Interface (OCI) connections. Also fixed a bug that cookie was immediately deleted after logging in with a session cookie. This was already fixed in the JCL the same way, but we never copied that fix to the GCL until now.
Type of change
Please check only ONE option.
How was this tested?
I tested if these models can be deserialized and serialized from and to XML. Nothing else to test.
Checklist before requesting a review
develop
as the base branch and notmain
, or the pull request is a hotfix that needs to be done directly onmain
Related pull requests
https://github.com/happy-geeks/HollandFoodService/pull/29
Link to Asana ticket
https://app.asana.com/0/1151477971646641/1206533774168789