Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed problem that links were sometimes not merged when they should be #605

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

GilianJuice
Copy link
Contributor

@GilianJuice GilianJuice commented Jun 26, 2024

Describe your changes

Fixed problem that links were sometimes not merged when they should be. This was caused by the fact that the ID of wiser_itemlink is not saved in wiser_history, but this code assumed that it was.

Type of change

Please check only ONE option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested?

I have tested these changes by making a fork database of a backup just before the moment that the original problem occurred. I then verified that I could reproduce the problem before making any changes and then tested my changes to see if they fixed the problem, which they did, and not cause new probems, which they didn't.

Checklist before requesting a review

  • I have reviewed and tested my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I selected develop as the base branch and not main, or the pull request is a hotfix that needs to be done directly on main
  • I double checked all my changes and they contain no temporary test code, no code that is commented out and no changes that are not part of this branch
  • I added new unit tests for my changes if applicable

Related pull requests

happy-geeks/wiser-task-scheduler#203

Link to Asana ticket

https://app.asana.com/0/7257459017111/1207597501842581/1207646424960318/f

@MikeVanMourik MikeVanMourik merged commit 26af81d into develop Jul 1, 2024
3 checks passed
@MikeVanMourik MikeVanMourik deleted the feature/branches-problem-with-merging-links branch July 1, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants