Request logging #597
Merged
Request logging #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansHappyHorizon
requested changes
Jun 19, 2024
…other projects, such as Wiser.
…lways return an ID.
GilianJuice
force-pushed
the
feature/request-logging
branch
from
9f4cbc0 to
3bb124c
Compare
Merge conflict solved. |
HansHappyHorizon
requested changes
Jun 19, 2024
| } | ||
| if (String.IsNullOrWhiteSpace(result)) | ||
| { | ||
| result = GetHeaderValueAs<string>(httpContext, "X_FORWARDED_FOR"); // TransIP and other providers use this. |
There was a problem hiding this comment.
It looks like the indentation here got a bit messed up after the rebase. Can you fix this?
There was a problem hiding this comment.
Sorry, didn't notice this. Is fixed now.
HansHappyHorizon
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added middleware to log all requests. This will log everything from the request and the response, but some sensitive information will be redacted in the logs. This is turned off by default and needs to be turned on if you want to use it in a project. If enabled, a new table
gcl_request_logwill be automatically created, the logs will be stored there.The middleware is made so that you can overwrite it in other projects to customize the logs. This will be used in Wiser to log requests that are done via it's API.
Type of change
Please check only ONE option.
How was this tested?
I have tested this by opening a test website and doing some requests and checking if my requests are being logged correctly. I have also tested this in the Wiser API to see if requests are logged correctly there too, after making customizations that are needed for Wiser. Wiser pull request will come later.
Checklist before requesting a review
developas the base branch and notmain, or the pull request is a hotfix that needs to be done directly onmainRelated pull requests
N/A
Link to Asana ticket
https://app.asana.com/0/1205090868730163/1205939790117085