Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set original_price if not exists when adding coupon #592

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

MKet
Copy link
Contributor

@MKet MKet commented May 31, 2024

Describe your changes

In handleCoupon setoriginal_price itemdetail to basket lines to the price value if it doesn't exist. Without this value the calculation later in this method results in a price of 0 which causes the coupon to be seen as invalid.

Type of change

Please check only ONE option.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How was this tested?

Please describe how you tested your changes and how you confirmed this functionality is not a breaking change.

Checklist before requesting a review

  • I have reviewed and tested my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I selected develop as the base branch and not main, or the pull request is a hotfix that needs to be done directly on main
  • I double checked all my changes and they contain no temporary test code, no code that is commented out and no changes that are not part of this branch
  • I added new unit tests for my changes if applicable

Related pull requests

N/A

Link to Asana ticket

https://app.asana.com/0/1151477971646641/1206533651519632

@MikeVanMourik MikeVanMourik merged commit c72b081 into develop Jun 3, 2024
3 checks passed
@MikeVanMourik MikeVanMourik deleted the feature/add-coupon-original-price branch June 3, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants