Fix test case for simulating a closed connection #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be happy to help maintaining this library? I'm not using Hapi anymore. |
|
@mcollina potentially - tho I've just started using it, so not sure if I'll stick to it |
|
Let us know! this module needs more love and attention than we can give. |
This was referenced Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix the test that's currently blocking #123, #124 and #125.
Tbh I'm not 100% sure if it's the right fix - for some reason, simulating a connection close seems to make hapi fail internally for POST requests, it has nothing to do with this test (the functionality seems to work fine AFAICT). For some reason, it works with GET requests though.
I'm adding a separate route with an artificial delay instead of just hitting
GET /something, as otherwise the assertion on the response time being greater than 0 is flaky, as it sometimes is 0, depending on how quick the test runs.