Updating kaoet's PR with your feedback

[paulcwarren]

Kaoet's PR would be very useful for us. However, he doesn't seem to have responded to your feedback so we are trying to pick up the thread.

We have asked questions on the original PR where we need some clarification.

Some other points to note:

• Unlike the original go-fuse code that is tested on Lucid. We require to run on Trusty/Xenial and therefore tested on this platform. We found that the --verbose option has been removed from flock in Trusty and therefore we had to relax the TestFlockExclusive test. We werent too pleased with the result but see no other option.
• We added comments where you have asked.
• We added @kaoet 's name and email to the AUTHORS file. Hopefully he wont mind!?!
• We added additional testing to ensure SetLk and SetLkw are called but we couldn't find a way to use flock to invoke GetLk. We tried cgo in an attempt to call fcntl.c but cgo isnt allowed in test files. Maybe you have some other ideas?

Feedback welcome. We really would like to work with you to get this PR merged as it would make our lives easier :-)

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[hanwen]

Hi Paul, happy to oblige and merge whatever you produce, but I need a CLA signoff, from you or your employer.

Thanks!

[kaoet]

To be honest, I implemented the flock just for my own project. And It just works fine these days.

Just pick up my code and do whatever you like. :)

[julian-hj]

Hi, just checking in on this--I believe that Paul & Maria have both signed the CLA. Is there something else we need to do? e.g. does @kaoet need to sign the CLA also?

Thanks!
-Julian

[hanwen]

verified CLA for Paul & Maria

[hanwen]

There were several items on kaoets original PR that weren't addressed. Can you have a look at those?

Also, the test, if run with the race detector, triggers a data race. Can you add synchronization so it doesn't trigger the detector?

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[mariash]

@googlebot confirming

[hanwen]

I fixed up the remaining issue (race conditions in test) and fixed some nits.

[paulcwarren]

Thanks @hanwen. Much appreciated.