Drop ArcFdGuard newtype #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a follow-up for this which replaces FdGuard with OwnedFd: ad90da8 |
hannobraun
approved these changes
Jan 14, 2025
This type existed because AsRawFd was not implemented for `Arc<T> where
T: AsRawFd`.
As for 1.63.0, the following implementation is provided:
impl<T: AsRawFd> AsRawFd for Arc<T>
The current MSRV is 1.70, so we can rely on this new implementation.
Drop the newtype wrapper, and rely on the new stdlib implementation
instead.
hannobraun
force-pushed
the
drop-ArcFdGuard
branch
from
42e4a83 to
16d867b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type existed because AsRawFd was not implemented for
Arc<T> where T: AsRawFd.As for 1.63.0, the following implementation is provided:
The current MSRV is 1.70, so we can rely on this new implementation.
Drop the newtype wrapper, and rely on the new stdlib implementation instead.