Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export watches::Watches at crate root. #205

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Re-export watches::Watches at crate root. #205

merged 1 commit into from
Jun 16, 2023

Conversation

zachs18
Copy link
Contributor

@zachs18 zachs18 commented Jun 15, 2023 •
edited
Loading

If watches::Watches is not exported publicly, then rustdoc does not show it's documentation, leading to broken doc links in Inotify::watches. (it is a pub item in a private module, so by default it can be used but not named)

See: Inotify::watches: the return type does not have an intra-doc link, and the intra-doc links to Watches::add and Watches::remove lead to 404 pages.

hannobraun
hannobraun approved these changes Jun 16, 2023
View reviewed changes
Copy link
Owner

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @zachs18, looks good!

@hannobraun hannobraun merged commit f189717 into hannobraun:master Jun 16, 2023
@eric-seppanen eric-seppanen mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannobraun hannobraun hannobraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachs18 @hannobraun