Replace event_stream() with into_event_stream() #199
Merged
+84
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds EventStream.into_inotify() to convert back to an Inotify. event_stream() was problematic because it could allow a caller to inadvertently create multiple streams reading and contending over the same source, resulting in unpredictable event emission.
hannobraun
approved these changes
Aug 22, 2022
edmondsfastly
added a commit
to fastly/dnstap-utils
that referenced
this pull request
Jan 13, 2024
See hannobraun/inotify-rs#199 Fixes the following diagnostics: warning: use of deprecated method `inotify::Inotify::event_stream`: use `into_event_stream()` instead, which enforces a single Stream and predictable reads --> src/bin/dnstap-replay/monitor_handler.rs:43:39 | 43 | let mut stream = self.inotify.event_stream(&mut buffer)?; | ^^^^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default warning: use of deprecated method `inotify::Inotify::add_watch`: use `Inotify.watches().add()` instead --> src/bin/dnstap-replay/monitor_handler.rs:166:26 | 166 | let wd = inotify.add_watch( | ^^^^^^^^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds EventStream.into_inotify() to convert back
to an Inotify.
event_stream() was problematic because it could allow
a caller to inadvertently create multiple streams
reading and contending over the same source, resulting
in unpredictable event emission.
Fixes #176