Device orientation #354
Merged
Device orientation #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 10, 2024 15:10
was setup to portrait despite of being used in all rendering and gyroscope calculations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just add the support for the Device orientation, in my use case the app is in landscape and your library does not work right with that.
It turns out that you already have a property for that
mCurrentDeviceOrientationbut it is private and set to Portrait in initialization.So i add the evaluation of this in the initial block of the PLManager class, with this the library now also works great in Landscape.
Also i change your PLViewListener methods to be open, otherwise it is not possible to override them in kotlin