Merge pull request #2 from hankei6km/topic/devcontainer

chore: Use node:18-bullseye to build devcontainer
hankei6km · Jul 16, 2023 · 4b6a402 · 4b6a402
2 parents c174bb0 + cff95c3
commit 4b6a402
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
@@ -1,7 +1,8 @@
-FROM mcr.microsoft.com/devcontainers/base:ubuntu
+FROM node:18-bullseye
 
 RUN apt update -y \
-    && apt install -y --no-install-recommends xvfb \
+    && apt install -y --no-install-recommends xauth libgtk-3-0 xvfb \
+    # playwright は実行時のバージョンと合わせる必要があるので、単純にインストールはできない。
     # && npm install -g @playwright/test \
     # && npx playwright install-deps \
     && rm -rf /var/lib/apt/lists/* 
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
@@ -6,7 +6,7 @@
       "username": "vscode"
     },
     "ghcr.io/devcontainers/features/github-cli:1": {},
-    "ghcr.io/devcontainers/features/node:1": {},
+    // "ghcr.io/devcontainers/features/node:1": {},
     "ghcr.io/devcontainers/features/rust:1": {}
   },