Fix PHP notice in WikiFile::getInfo() (fixes #84) #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xymph
force-pushed
the
84-fix-getinfo-notice
branch
from
6a5acd0 to
8cc4898
Compare
Merged
waldyrious
reviewed
Mar 13, 2017
Wikimate.php
Outdated
| @@ -1097,7 +1097,7 @@ public function getInfo($refresh = false, $history = null) | |||
|
|
|||
| $this->edittoken = $page['edittoken']; | |||
|
|
|||
| if (!isset($page['missing'])) { | |||
| if (!isset($page['missing']) && isset($page['imageinfo'])) { | |||
There was a problem hiding this comment.
Do you think a comment would be warranted above this line? I'm not sure the behavior you described in #84 is intuitive:
when a file existed but was subsequently deleted or moved to another path, that the MW API does not return the
missingproperty for the requested path anymore. I guess it only does that when the path never existed in the first place.
There was a problem hiding this comment.
Yes, good point - done.
|
LGTM. Feel free to do any commit cleanup if you feel it's worth it, and merge whenever you're ready. |
Xymph
force-pushed
the
84-fix-getinfo-notice
branch
from
6fbc6a7 to
e7022dc
Compare
|
I fixed up the comment with the code change, but preserved the reference to the changelog discussion. That's a wrap. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #84.