Swipe recognizer using overall gesture direction and velocity instead of last interval #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if horizontal direction is negative, it should return “Left”, not “Right”. this resulted in direction and offsetDirection properties to have opposite values
swipe should detect the overall swipe direction, not the last interval one more importantly, it should use the overall velocity, so that if you’ve swiped but slowed the motion down before touchend, swipe is still detected. need to capture overallVelocity for these tests, which we didn’t have
if after pinch/rotate, one finger touchends before the other, swipe is incorrectly triggered because the last gesture is a single-touch gesture. this checked for maximum pointers in gesture
|
I think swipe is fairly broken until you apply this patch, this should be merged asap. |
|
Admins, could this PR be merged please? |
|
Probably not getting merged until #749 gets resolved, unfortunately |
upstream
|
Hi we will look into this ASAP once we finish trying to clean up the issues a little. Hoping to do a quick patch release with this and some other fixes. |
|
Reading over this i think this seems like the correct change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #640. Swipe recogniser should depend on overall direction (offsetDirection) and overall velocity (overallVelocity) instead of the ones of the last interval. Makes this more sensitive to swipes that slow down before touchend.
Added "overallVelocity" property in input which takes into account the total gesture time and the overall distance moved.
Prerequisite to fix issue #639 where the inverse value was returned for offsetDirection, also fixed in this PR.
also added a fix for swipe incorrectly triggering after pinch/rotate if one finger touchends before the other.