Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll isn't disable on drag events with iOS 9.3 #952

Closed
ghost opened this issue Mar 29, 2016 · 18 comments
Closed

Scroll isn't disable on drag events with iOS 9.3 #952

ghost opened this issue Mar 29, 2016 · 18 comments

Comments

@ghost
Copy link

ghost commented Mar 29, 2016

Hi everybody,

Scroll isn't disable on drag events with iOS 9.3.
I have compared with old ios version and all it's good !

Best,

Adrien

@arschmitz
Copy link
Contributor

Thank you for reporting this. Im already working on a patch for it. This is because of iOS incomplete implementation of touch-action we now need to not just check if its supported but if it supports none

@ghost
Copy link
Author

ghost commented Mar 29, 2016

Ok ! Thanks @arschmitz for your precisions

@simonwidjaja
Copy link

Hey guys. What is the best way to interim fix this?
(BTW: Keep up the great work!)

@arschmitz
Copy link
Contributor

im not sure there is a simple fix working to get this fixed but been busy hope to get it done this weekend

@ghost
Copy link
Author

ghost commented Apr 1, 2016

Read last message ! https://bugs.webkit.org/show_bug.cgi?id=149854
I did not understand everything, but it may be a solution…

@arschmitz
Copy link
Contributor

@adrienbecker thats unrelated to this but thank you

@ghost
Copy link
Author

ghost commented Apr 1, 2016

failed

@arschmitz
Copy link
Contributor

@adrienbecker no worries that was the cause with some issues in some of my other libraries not totally off base or anything just not this particular issue. Thats for touch-action manipulation to work ( the only value supported by webkit ). In your case touch action none is the issue which is just not supported by webkit at all. We fake it when its not supported. Problem is we check for support of touch-action as a whole not the individual props since we never expected someone ( apple ) to implement just one value and not the rest.

@jtangelder
Copy link
Member

I guess this can be checked with CSS.supports('touch-action', 'none');. But I don't have an iPhone to confirm that this will work. Do you @arschmitz? This will be an easy fix then. In touchAction.js is a condition to detect native support, we could easily enhance it.

@jtangelder
Copy link
Member

#955 a PR, can anyony verify this fix?

@runspired
Copy link
Contributor

@jtangelder I have an iPhone but I've avoided upgrading to 9.3 due to this... :/

Guess I need to take the leap?

@arschmitz
Copy link
Contributor

@jtangelder @runspired i have one upgraded @runspired see comment on #955 though

@ghost
Copy link
Author

ghost commented Apr 4, 2016

@arschmitz Great ! It works fine :)

@ghost ghost closed this as completed Apr 4, 2016
@ghost
Copy link
Author

ghost commented Apr 4, 2016

Can you update the npm package ?

@arschmitz
Copy link
Contributor

We will do a new release with this and some other fixes some time this week i would think.

@jbach
Copy link

jbach commented Apr 12, 2016

Any updates on the npm release?

@ghost
Copy link
Author

ghost commented Apr 12, 2016

Pull request #956 is always open

@zakness
Copy link

zakness commented Apr 21, 2016

For anyone coming across this, a quick fix might be to call event.preventDefault() in your handler. This has worked for me for pan and pinch (haven’t tried others).

jberglinds added a commit to dkmkth/clicker that referenced this issue Aug 23, 2016
Bug in 2.0.6 left viewport scroll enabled on swipe for iOS 9.3+ devices.
hammerjs/hammer.js#952
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants