Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup temp.tsconfig.json if build fails #5

Closed
hamlim opened this issue May 21, 2024 · 0 comments · Fixed by #7
Closed

Cleanup temp.tsconfig.json if build fails #5

hamlim opened this issue May 21, 2024 · 0 comments · Fixed by #7
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@hamlim
Copy link
Owner

hamlim commented May 21, 2024

Right now - if there's a build error (e.g. in SWC, set target to ecmascript and try to export type Foo = 'string'), the temp.tsconfig.json file will still be output to the file system and it won't be cleaned up.

We should cleanup in a failure!

@hamlim hamlim added bug Something isn't working good first issue Good for newcomers labels May 21, 2024
hamlim added a commit that referenced this issue May 21, 2024
hamlim added a commit that referenced this issue May 21, 2024
@hamlim hamlim closed this as completed in #7 May 21, 2024
hamlim added a commit that referenced this issue May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant