Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add LICENSE as META-INF/LICENSE, add Bundle-License header #264

Closed
vlsi opened this issue Jun 29, 2019 · 3 comments · Fixed by #414
Closed

Please add LICENSE as META-INF/LICENSE, add Bundle-License header #264

vlsi opened this issue Jun 29, 2019 · 3 comments · Fixed by #414

Comments

@vlsi
Copy link
Contributor

vlsi commented Jun 29, 2019

  1. Thanks for Hamcrest

  2. Current hamcrest.jar are hard to bundle into other software due to missing licensing information.

Suggested changes are:

2.1) Package license as META-INF/LICENSE. Current one is LICENSE.txt, and de-facto standard is META-INF/LICENSE. The license files packaged at the root cause problems with Android.
Basically whoever makes an uberjar they have to implement "license merger", and typically they configure for META-INF/LICENSE.
2.2) Please add Bundle-License: BSD-3-Clause manifest entry (where BSD-3-Clause is SPDX identifier, see https://osgi.org/specification/osgi.core/7.0.0/framework.module.html#framework.module-bundle-license )
Unfortunately, there are lots of BSD-style licenses, and it is hard to tell what "New BSD License" means.
2.3) Even though 2.1 and 2.2 would be great, you might want to use BSD-3-Clause for <licence><name> tag in pom.xml. The use of SPDX in pom is not common yet, however BSD-3-Clause there would help even humans.

@tumbarumba
Copy link
Member

This seems like a reasonable improvement. Are you able to create a pull request with these changes?

@vlsi
Copy link
Contributor Author

vlsi commented Apr 29, 2023

@tumbarumba , here's a PR: #399

@vlsi
Copy link
Contributor Author

vlsi commented Jul 23, 2024

@tumbarumba , PR #414 does not include LICENSE file to the generated jar. Would you please include it?

ndwlocatieservices added a commit to ndwnu/nls-routing-map-matcher that referenced this issue Oct 14, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [org.hamcrest:hamcrest-library](http://hamcrest.org/JavaHamcrest/) ([source](https://github.com/hamcrest/JavaHamcrest)) | test | major | `2.2` -> `3.0` |

---

### Release Notes

<details>
<summary>hamcrest/JavaHamcrest (org.hamcrest:hamcrest-library)</summary>

### [`v3.0`](https://github.com/hamcrest/JavaHamcrest/blob/HEAD/CHANGES.md#Version-30-1st-August-2024)

[Compare Source](hamcrest/JavaHamcrest@v2.2...v3.0)

##### Breaking Changes

-   From version 3.0, the jar distributed to Maven Central is now compiled to Java 1.8 bytecode,
    and is not compatible with previous versions of Java. See
    [Issue #&#8203;331](hamcrest/JavaHamcrest#331) and
    [PR #&#8203;411](hamcrest/JavaHamcrest#411) for details. Developers who use Java 1.7 earlier can still
    depend upon `hamcrest-2.2.jar`.

##### Improvements

-   FileMatchersTest simplification ([PR #&#8203;389](hamcrest/JavaHamcrest#389))
-   License cleanup ([PR #&#8203;414](hamcrest/JavaHamcrest#414),
    [PR #&#8203;415](hamcrest/JavaHamcrest#415), see also
    [#&#8203;264](hamcrest/JavaHamcrest#264),
    [#&#8203;355](hamcrest/JavaHamcrest#355),
    [#&#8203;396](hamcrest/JavaHamcrest#396
    [#&#8203;399](hamcrest/JavaHamcrest#399))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or rename PR to start with "rebase!".

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants