Skip to content

feat: migrate to github.com/urfave/cli/v3 #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Conversation

nrwiersma
Copy link
Member

Goal of this PR

This migrates the CLI to v3, moving this module to v3 as well, due to the breaking change.

How did I test it?

@nrwiersma nrwiersma requested a review from Copilot April 8, 2025 05:21
@nrwiersma nrwiersma self-assigned this Apr 8, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (3)

trace.go:54

  • The flag type for 'FlagTracingTags' has been changed from StringSliceFlag to StringMapFlag; please ensure that downstream code consuming this flag is updated to handle map values rather than slices.
&cli.StringMapFlag{

profile.go:102

  • Consider validating that each entry in newTypes corresponds to a supported profiling type before conversion to pyroscope.ProfileType to avoid unintended behavior at runtime.
if newTypes := cmd.StringSlice(FlagProfilingTypes); len(newTypes) > 0 {

observe/observer.go:102

  • Using context.WithoutCancel(ctx) for tracer shutdown bypasses any cancellation or timeout; please verify that this is the intended behavior for a graceful shutdown in all scenarios.
closeFns = append(closeFns, func() { _ = tracer.Shutdown(context.WithoutCancel(ctx)) })

@nrwiersma nrwiersma merged commit 1eafdbb into main Apr 8, 2025
1 check passed
@nrwiersma nrwiersma deleted the vnext branch April 8, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant