Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use index mechanism to query links and groups #65

Merged
merged 1 commit into from
May 30, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented May 29, 2024

What this PR does?

使用索引机制查询链接和分组

/kind improvement

Fixes #64, #60

使用索引机制查询链接和分组

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels May 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby May 29, 2024 10:33
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
Copy link

f2c-ci-robot bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit c250cde into main May 30, 2024
4 checks passed
@ruibaby ruibaby deleted the refactor/indexed-links branch May 30, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

请问一下linkfinder中的listby方法中删除时间不能为空有什么意义吗?
2 participants