Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ready "Prepare Phase RFC" #1

Closed
wants to merge 5 commits into from
Closed

make ready "Prepare Phase RFC" #1

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45e3cb5
DRAFT prepare-phase from old commit.
haliliceylan Jun 7, 2021
7c6f572
Update 0000-prepare-phase.md
haliliceylan Jun 7, 2021
637212d
delete stack buildpacks
haliliceylan Jun 7, 2021
01478e2
delete old information which is not valid anymore
haliliceylan Jun 7, 2021
2152fc5
Apply suggestions from code review
haliliceylan Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions text/0000-prepare-phase.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Meta
[meta]: #meta
- Name: Prepare Phase
- Start Date: 2021-01-13
- Author(s): [@jkutner](github.com/jkutner/)
- Start Date: 2021-06-08
- Author(s): [@jkutner](github.com/jkutner/) & [@natalieparellano](github.com/natalieparellano/) & [@haliliceylan](github.com/haliliceylan/)
- RFC Pull Request: (leave blank)
- CNB Pull Request: [buildpacks/spec#176](https://github.com/buildpacks/spec/pull/176)
- CNB Issue: (leave blank)
Expand All @@ -22,15 +22,16 @@ This is a proposal for a new Lifecycle phase, called "prepare", that would run b
# Motivation
[motivation]: #motivation

Parity with Pack: A Lifecycle Prepare phase should make it easier for Platform Implementers to achieve parity with features of Pack. Today, features like project.toml are only supported by Pack, and a new platform would need to write it’s own parser.
haliliceylan marked this conversation as resolved.
Show resolved Hide resolved

The prepare phase would support the following features and capabilities:
* [Stack buildpacks](https://github.com/buildpacks/rfcs/pull/111), which require a phase to read run-image mixins validation prior to detection
haliliceylan marked this conversation as resolved.
Show resolved Hide resolved
* [Inline buildpacks](https://github.com/buildpacks/rfcs/blob/main/text/0048-inline-buildpack.md), which require parsing of the `project.toml` in the lifecycle
haliliceylan marked this conversation as resolved.
Show resolved Hide resolved
* [Lifecycle configuration](https://github.com/buildpacks/rfcs/pull/128)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to list exactly what would be configured. Though perhaps it's worth noting, the linked RFC was closed (I forget exactly why). Maybe it isn't a concern anymore.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually i am little bit confusing about what would be configured. This is Draft RFC is little bit old and a lot of links are already merged or closed. The issue is not providing any technical information (except your comment). What should i do to find correct list for here ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take it out for now, if there's a need surely others will suggest it :)


# What it is
[what-it-is]: #what-it-is

The prepare phase will run before all other phases, and prepare the execution environment for a buildpack build. This phase will have access to secrets and credentials used to access registries and other services.
A new Lifecycle phase and associated binary should be available to Platform Implementers, and should be executed by Pack. The prepare phase will run before all other phases, and prepare the execution environment for a buildpack build. This phase will have access to secrets and credentials used to access registries and other services.

## Responsibilities

Expand Down