Disable zstd in llvm in our llvm build instructions #8407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM recently started defaulting ENABLE_ZSTD to on, but on macos brew puts libzstd into a directory that's not in the linker search path, and llvm-config --system-libs declares a dependency on zstd but doesn't add the correct search path. It's not clear why we need llvm with zstd, so I'm proposing just disabling it in our build instructions to avoid this failure mode.
alexreinking
approved these changes
Sep 3, 2024
|
Are you saying we should just copy-paste the whole list in pip.yml to avoid building unnecessary things? |
Yes, less the obviously ci-specific stuff, like the install prefix. On mobile, sorry. |
|
Superseded by #8410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM recently started defaulting ENABLE_ZSTD to on, but on macos brew puts libzstd into a directory that's not in the linker search path, and llvm-config --system-libs declares a dependency on zstd but doesn't add the correct search path. It's not clear why we need llvm with zstd, so I'm proposing just disabling it in our build instructions to avoid this failure mode.