Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python_bindings-test-as-installed #8355

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

LebedevRI
Copy link
Contributor

@LebedevRI LebedevRI commented Jul 27, 2024

Support not building python bindings, while running python tests against installed halide, and call enable_testing() there so that ctest can work.

Extracted from pending debian package changes.

Support not building python bindings, while running python tests
against installed halide, and call `enable_testing()` there
so that `ctest` can work.
@LebedevRI
Copy link
Contributor Author

Ah yes, that makes more sense.
Thank you for taking a look!

@alexreinking
Copy link
Member

This looks good, thanks for the patch!

@LebedevRI
Copy link
Contributor Author

Failure looks unrelated.

@steven-johnson steven-johnson merged commit 423df3c into halide:main Jul 31, 2024
15 of 16 checks passed
@LebedevRI
Copy link
Contributor Author

@steven-johnson @alexreinking thank you!

While there, a question:
python bindings are pulled in/required when doing find_package(Halide).
Has there been any thought about splitting that up?
It seems somewhat especially surprising given that said bindings can be built standalone.

@LebedevRI LebedevRI deleted the python-cmake branch July 31, 2024 16:49
@alexreinking
Copy link
Member

alexreinking commented Jul 31, 2024

Yes, that's on my todo list. As is making what is now HalideHelpers into the primary package and putting the libraries and autoschedulers in HalideLibs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants