Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Xcode issue that requires at least one source file when building a library from objects. #6175

Merged
merged 2 commits into from
Jul 31, 2021
Merged

Fix Xcode issue that requires at least one source file when building a library from objects. #6175

merged 2 commits into from
Jul 31, 2021

Conversation

alexreinking
Copy link
Member

@alexreinking alexreinking commented Jul 29, 2021 •
edited
Loading

ATTN: @popizdeh -- please test this and confirm whether it works for you.

We don't test Xcode on CI (we use Ninja on all platforms) so adding skip_buildbots here.

Fixes #6167

@alexreinking alexreinking added the skip_buildbots Synonym for buildbot_test_nothing label Jul 29, 2021
@alexreinking alexreinking mentioned this pull request Jul 29, 2021
Closed
@popizdeh
Copy link

Looking good on my end Alex. Thanks a lot!

@alexreinking alexreinking merged commit e52d6ca into master Jul 31, 2021
@alexreinking alexreinking deleted the cmake/xcode-fix branch July 31, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abadams abadams abadams approved these changes

@steven-johnson steven-johnson Awaiting requested review from steven-johnson

Assignees
No one assigned
Labels
skip_buildbots Synonym for buildbot_test_nothing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake Xcode generator appears broken
3 participants
@alexreinking @popizdeh @abadams