Rewrite Rules Evaluation Project - Merging Relevant Synthesized Rewrite Rules #6174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abadams
reviewed
Jul 29, 2021
rootjalex
reviewed
Jul 30, 2021
| @@ -191,6 +210,7 @@ Expr Simplify::visit(const Select *op, ExprInfo *bounds) { | |||
| (no_overflow_int(op->type) && | |||
| (rewrite(select(x, y * c0, c1), select(x, y, fold(c1 / c0)) * c0, c1 % c0 == 0) || | |||
| rewrite(select(x, c0, y * c1), select(x, fold(c0 / c1), y) * c1, c0 % c1 == 0) || | |||
| rewrite(select(x, y + c0, c1), select(x, y, fold(c1 - c0)) + c0) || | |||
There was a problem hiding this comment.
This rule is causing the correctness_simplify failures. We should either remove it or possibly add a c1 != 0 predicate.
rootjalex
reviewed
Aug 2, 2021
…enyc/Halide into evan-merge-selected-rules
|
@steven-johnson are the buildbot failures due to an LLVM breakage, or are they due to this PR? I don't see the failure on other PRs so I am assuming the latter, but just wanting to check |
LLVM breakage. Should be safe to ignore. |
rootjalex
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conducted experiments to analyze the performance effects of adding 4000+ synthesized rewrite rules to Halide.
Narrowed down the rules to 11 rewrite rules whose associative & commutative variants are added in this PR.
With these rewrite rules, Halide achieves >10% peak memory reductions in 192 cases in apps including camera_pipe, harris, nl_means, and stencil_chain, which is similar to the results (with all 4000+ rules) from this paper - https://dl.acm.org/doi/pdf/10.1145/3428234