Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup for Debian packaging #5886

Merged
merged 4 commits into from
Apr 7, 2021
Merged

Code cleanup for Debian packaging #5886

merged 4 commits into from
Apr 7, 2021

Conversation

alexreinking
Copy link
Member

@alexreinking alexreinking commented Apr 7, 2021 •
edited
Loading

This is split out from #5754 to make it easier to review later.

  • Fix spelling mistakes found by Debian's lintian tool.
  • Remove -O2 from presets, which we determined added no value
  • Remove reference to WITH_APPS from docs, which is now fully external.
  • Add shebang line to autotune_loop.sh to make it a valid executable script (ie. chmod +x).

Please rebase this, rather than squashing it to save me some trouble updating #5754

@alexreinking alexreinking added the code_cleanup No functional changes. Reformatting, reorganizing, or refactoring existing code. label Apr 7, 2021
@alexreinking alexreinking merged commit 71b895e into master Apr 7, 2021
@alexreinking alexreinking deleted the cpack/pre-pr-cleanup branch April 7, 2021 22:51
@alexreinking alexreinking added this to the v12.0.0 milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-johnson steven-johnson steven-johnson approved these changes

Assignees
No one assigned
Labels
code_cleanup No functional changes. Reformatting, reorganizing, or refactoring existing code.
Projects
None yet
Milestone
v12.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alexreinking @steven-johnson